Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Code LGTM, this is a nice little big improvement , thank you 🙏 ... tested a-la-carte and works as expected. Just one note, the text in the PR doesn't mention what was changed (like added fancy brackets). this could be added

Good call, summary updated to include changes.

LGTM,

I come up with this edge case, 3 values, but look like 5 (except subtle color difference in commas) :

But I don't think this is a blocker, since we had same edge case in main and overall changes makes formatting better

this is a neat edge case @Dosant , also do agree it shouldn't block, but it's good to be aware of this 👍 . BTW there are no plans to add React based formatters which would e.g. allow expand/collapse such a list in UI, are there?

@elasticmachine merge upstream

there are no plans to add React based formatters which would e.g. allow expand/collapse such a list in UI, are there?

There are no plans, but there is this bug in the backlog: #75729, which I think could be fixed with some kind of React-based formatter where internally it updates with an interval

Another use-case I had in mind is that we possibly could use lazy-loading inside such React-based formatter and stop loading some of those heavy formatting functions into the initial bundle with all the formatters

I think it is worth at least creating an issue even if this won't be escalated soon

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: c4ec410
• Storybooks Preview

Failed CI Steps

• FTR Configs #30

Test Failures

• [job] [logs] FTR Configs #30 / machine learning - data visualizer index based actions panel on trial license view in discover page action loads the source data in the data visualizer

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

History

• 💚 Build #59718 succeeded ebebb66
• 💚 Build #59235 succeeded e6c388d1cc2951a962e00675e1864aa5b84f6509
• 💚 Build #58895 succeeded 6731fa3dbd686f4c0230f12a3389d7db9ae09a59

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

I come up with this edge case, 3 values, but look like 5 (except subtle color difference in commas) :

Oh yeah, good catch. I guess to the very keen eye the comma colours could help, but definitely not ideal. This will be good to keep in mind if we later go the React direction.